[Bug 23690] Return value from xcb_generate_id() not checked

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=23690


Alan Coopersmith <alan.coopersmith-xsfywfwIY+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |xcb-***@public.gmane.org

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=23690

Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |2011BRB_Reviewed
AssignedTo|xorg-team-go0+***@public.gmane.org |jamey-sH+B+***@public.gmane.org
CC| |jeremyhu-CC+***@public.gmane.org

--- Comment #2 from Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> 2011-10-08 19:48:52 PDT ---
Looking through libX11's git log, I don't see this. What's the status of it?

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=23690

--- Comment #3 from ajax at nwnk dot net <ajax-***@public.gmane.org> 2011-12-16 12:55:44 PST ---
BadIDChoice isn't something the client is expected to handle gracefully. Or
even capable of handling gracefully, for that matter; XID choice is xlib's job.

The paths through which xcb_generate_id can return -1 are, afaict, exactly
those paths that are fatal: either the socket is already in an error condition,
or the server doesn't support XC-MISC, or the server thinks the client is
literally out of XIDs. It might be interesting to see which of these it is.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23690

GitLab Migration User <gitlab-***@fdo.invalid> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |MOVED
Status|NEW |RESOLVED

--- Comment #4 from GitLab Migration User <gitlab-***@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/xorg/lib/libx11/issues/7.