[Xcb] New pthread-stubs release?

Discussion:

Uli Schlachter

2017-03-06 12:48:40 UTC

Permalink

Hi,

assuming the FreeBSD issue really no longer applies: Should we do a new
pthread-stubs release soon-ish?

Uli

--
“Cold. Cold. Cold. Cold. Cold. Cold. Cold. Cold. Cold. Cold.” – Anna

Matt Turner

2017-03-08 17:05:58 UTC

Permalink

Post by Uli Schlachter
assuming the FreeBSD issue really no longer applies: Should we do a new
pthread-stubs release soon-ish?

Sounds good to me. Doesn't seem like we're going to hear anything back
from the FreeBSD developers.

Thanks for doing this!

Emil Velikov

2017-03-10 18:42:40 UTC

Permalink

Post by Matt Turner

Post by Uli Schlachter
assuming the FreeBSD issue really no longer applies: Should we do a new
pthread-stubs release soon-ish?

Sounds good to me. Doesn't seem like we're going to hear anything back
from the FreeBSD developers.

I've poked one of their devs on IRC. Hopefully we'll hear from their
thread(s) people soon~ish.

I'd love to get a pthread-stubs version bump for the next MESA. As we
go into feature freeze is in ~5 weeks, it's not that big of a rush.

Thanks
Emil

Christian Linhart

2017-03-11 10:58:06 UTC

Permalink

Hi Uli,

When you prepare the release please update the version-dependency
between libxcb and proto.

There is at least one change so that libxcb only builds when proto is up to date.

The dependency is in https://cgit.freedesktop.org/xcb/libxcb/tree/configure.ac#n53
as far as I know.
The line is:
PKG_CHECK_MODULES(XCBPROTO, xcb-proto >= 1.12)

Thank you,

Chris

Post by Uli Schlachter
Hi,
assuming the FreeBSD issue really no longer applies: Should we do a new
pthread-stubs release soon-ish?
Uli

Uli Schlachter

2017-03-11 11:19:26 UTC

Permalink

Hi Christian,

Post by Christian Linhart
When you prepare the release please update the version-dependency
between libxcb and proto.
There is at least one change so that libxcb only builds when proto is up to date.

I only plan to do a pthread-stubs release. No libxcb or xcb-proto
release. But thanks for the pointer. :-)

I'll switch the topic:

Thanks for your work on the Input protocol. Sorry that I cannot help
much there. However, I was wondering about: What is the state of XInput
support in XCB? As far as I know, it is the only remaining extension
that is of wider interest[1] and that is not enabled by default in XCB.
Do we have a list of remaining issues or something like that?

[1]: This seems to exclude Xprint and SELinux.

Thanks!

Cheers,
Uli

--
If you have to type the letters "A-E-S" into your source code, you're
doing it wrong.

Christian Linhart

2017-03-11 12:27:50 UTC

Permalink

Hi Uli,

I think that XINPUT-support in XCB is complete now, with the changes that I have pushed today.
However, I'd like to get at least one second opinion on that before we enable it by default.

Especially, the newest changes in
https://cgit.freedesktop.org/xorg/proto/inputproto/
should be cross-checked with xinput.xml in xcb/proto.
Most of my changes are based on the state of the XINPUT-spec from 2014 or so.

Thank you for asking for a list of remaining issues:
There is such a list: it is in the comment at the beginning of xinput.xml.
I have forgotten about this list, and therefore forgotten to remove it.
I'll post a patch for that, soon.

Cheers,

Chris

P.S.: I didn't realize that pthread_stubs is an extra library. :-)

Post by Uli Schlachter
Hi Christian,

I only plan to do a pthread-stubs release. No libxcb or xcb-proto
release. But thanks for the pointer. :-)
Thanks for your work on the Input protocol. Sorry that I cannot help
much there. However, I was wondering about: What is the state of XInput
support in XCB? As far as I know, it is the only remaining extension
that is of wider interest[1] and that is not enabled by default in XCB.
Do we have a list of remaining issues or something like that?
[1]: This seems to exclude Xprint and SELinux.
Thanks!
Cheers,
Uli

Uli Schlachter

2017-03-11 17:05:31 UTC

Permalink

Hi Christian,

Post by Christian Linhart
I think that XINPUT-support in XCB is complete now, with the changes that I have pushed today.
However, I'd like to get at least one second opinion on that before we enable it by default.

Sounds good, thanks for the info. I do not feel qualified to give that
second opinion, sorry.

Post by Christian Linhart
Especially, the newest changes in
https://cgit.freedesktop.org/xorg/proto/inputproto/
should be cross-checked with xinput.xml in xcb/proto.
Most of my changes are based on the state of the XINPUT-spec from 2014 or so.

[...]

At least the changes from 2016 and 2017 only touch autotools-files and
so are not relevant here...

Cheers,
Uli

--
If you have to type the letters "A-E-S" into your source code, you're
doing it wrong.

Bart Massey

2017-03-11 19:58:24 UTC

Permalink

Speaking just for myself, I'm quite comfortable at this point with just
enabling XINPUT and letting the chips fall where they may. The work seems
at first glance to be excellently and professionally done. Enabling the
changes almost certainly wouldn't leave things any worse than they are now
with regard to XINPUT, and I am skeptical that there are breaking changes
to the rest of XCB. A test suite would be nice, but I doubt anybody has the
time and energy to write one: I know I don't. So I think let's do the "user
testing" thing. But I'm not a maintainer anymore (except maybe of the image
library), so it's definitely not my call...

Post by Uli Schlachter
Hi Christian,

Post by Christian Linhart
I think that XINPUT-support in XCB is complete now, with the changes

that I have pushed today.

Post by Christian Linhart
However, I'd like to get at least one second opinion on that before we

enable it by default.
Sounds good, thanks for the info. I do not feel qualified to give that
second opinion, sorry.

or so.
[...]
At least the changes from 2016 and 2017 only touch autotools-files and
so are not relevant here...
Cheers,
Uli
--
If you have to type the letters "A-E-S" into your source code, you're
doing it wrong.
_______________________________________________
Xcb mailing list
https://lists.freedesktop.org/mailman/listinfo/xcb

Christian Linhart

2017-03-13 14:52:46 UTC

Permalink

Hi Bart,

Thank you for taking a look and for your feedback.
I agree with you to just enable XINPUT and see what happens.

I'll post a patch for this soon.

To the state of QA-testing:

You are probably right that nobody has the time to write a test-suite.
(Though this could be a good project for OPW. It won't matter if it'll be half-finished. Half a testsuite will already be useful.)

There has already been QA testing for the stuff in xcb/proto, i.e., xinput.xml and xcbgen:
This is in use with another generator in my commercial product.
I.e., the protocol definitions are tested to the extent which is relevant in my product.
So, we won't throw untested stuff to users.
It'll be more for the fine-tuning. :-)

For some of the changes in xinput I have written testcases for libxcb, e.g., for SendExtensionEvent.
Mostly to test new features that I have added to the generator.

Cheers,

Chris

Speaking just for myself, I'm quite comfortable at this point with just enabling XINPUT and letting the chips fall where they may. The work seems at first glance to be excellently and professionally done. Enabling the changes almost certainly wouldn't leave things any worse than they are now with regard to XINPUT, and I am skeptical that there are breaking changes to the rest of XCB. A test suite would be nice, but I doubt anybody has the time and energy to write one: I know I don't. So I think let's do the "user testing" thing. But I'm not a maintainer anymore (except maybe of the image library), so it's definitely not my call...
Hi Christian,

Sounds good, thanks for the info. I do not feel qualified to give that
second opinion, sorry.

[...]
At least the changes from 2016 and 2017 only touch autotools-files and
so are not relevant here...
Cheers,
Uli
--
If you have to type the letters "A-E-S" into your source code, you're
doing it wrong.
_______________________________________________
Xcb mailing list
https://lists.freedesktop.org/mailman/listinfo/xcb
_______________________________________________
Xcb mailing list
https://lists.freedesktop.org/mailman/listinfo/xcb

Peter Hutterer

2017-03-12 22:26:16 UTC

Permalink

Post by Christian Linhart
Hi Uli,
I think that XINPUT-support in XCB is complete now, with the changes that I have pushed today.
However, I'd like to get at least one second opinion on that before we enable it by default.

ah, that's great to hear, thanks!

there haven't been any serious changes to the protocol since inputproto 2.3
(March 2013), it was just spit and polish after that. The only one that
could have an effect on xcb is
https://cgit.freedesktop.org/xorg/proto/inputproto/commit/?id=c2cf8cab4aa781306ff26b171107d26f12bac015
but that one only if you managed to copy that typo :)

Cheers,
Peter

Post by Christian Linhart
There is such a list: it is in the comment at the beginning of xinput.xml.
I have forgotten about this list, and therefore forgotten to remove it.
I'll post a patch for that, soon.
Cheers,
Chris
P.S.: I didn't realize that pthread_stubs is an extra library. :-)

Post by Uli Schlachter
Hi Christian,

Christian Linhart

2017-03-13 14:48:17 UTC

Permalink

Hi Peter,

Thank you for your info about the relevant changes in the spec.
Good to hear that there weren't any relevant changes since I cross-checked the spec with the xml.

The typoe that you mentioned is not relevant for the xinput.xml because the mask is directly defined there, without an intermediate constant:
https://cgit.freedesktop.org/xcb/proto/tree/src/xinput.xml?id=97fbba25baf241cbcda882739db423b1d36e440a#n1577

So, this looks good.

Cheers,

Chris

Post by Peter Hutterer

ah, that's great to hear, thanks!

Post by Uli Schlachter
Hi Christian,

_______________________________________________
Xcb mailing list
https://lists.freedesktop.org/mailman/listinfo/xcb