[Bug 53242] xwininfo segfaults on invalid screen

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |xcb-***@public.gmane.org

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

--- Comment #1 from Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> 2012-08-25 19:12:29 UTC ---
With current master (5037f79e8f6a36d3c524a2dd8150cf96c31b7106):

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000001
0x00000001000016e1 in Select_Window (dpy=0x10081bc00, screen=0x100822bd4,
descend=1) at dsimple.c:180
180 if (grab_reply->status != XCB_GRAB_STATUS_SUCCESS)
(gdb) bt
#0 0x00000001000016e1 in Select_Window (dpy=0x10081bc00, screen=0x100822bd4,
descend=1) at dsimple.c:180
#1 0x00000001000031bf in main (argc=4, argv=0x7fff5fbff950) at xwininfo.c:573
Current language: auto; currently minimal
(gdb) print grab_reply
$1 = (xcb_grab_pointer_reply_t *) 0x0
(gdb)

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--- Comment #2 from Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> 2012-08-25 19:16:20 UTC ---
Took the question of where to check, libxcb or callers like xwininfo,
to the xcb mailing list for discussion:
http://lists.freedesktop.org/archives/xcb/2012-August/007840.html

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

--- Comment #3 from Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> 2012-08-25 19:37:25 UTC ---
Created attachment 66113
--> https://bugs.freedesktop.org/attachment.cgi?id=66113
0001-Return-connection-failure-if-display-string-specifie.patch

Here's a patch for libxcb based on alanc's libxcb patch, but it introduces a
new error code to allow callers to tell the difference between the two errors.

[Kaitlyn Maglione]

Stop

Sent from my iPhone

Post by bugzilla-daemon-CC+
https://bugs.freedesktop.org/show_bug.cgi?id=53242
Created attachment 66113
--> https://bugs.freedesktop.org/attachment.cgi?id=66113
0001-Return-connection-failure-if-display-string-specifie.patch
Here's a patch for libxcb based on alanc's libxcb patch, but it introduces a
new error code to allow callers to tell the difference between the two errors.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Xcb mailing list
http://lists.freedesktop.org/mailman/listinfo/xcb

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #66113|0 |1
is obsolete| |

--- Comment #4 from Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> 2012-08-25 19:50:49 UTC ---
Created attachment 66114
--> https://bugs.freedesktop.org/attachment.cgi?id=66114
libxcb patch, introducing XCB_CONN_CLOSED_INVALID_SCREEN

Addresses a couple issues in the original patch

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #66114|0 |1
is obsolete| |

--- Comment #5 from Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> 2012-08-25 19:59:06 UTC ---
Created attachment 66115
--> https://bugs.freedesktop.org/attachment.cgi?id=66115
Yet another revision of libxcb patch

Merged my fixes with Jeremy's improvements to the previous libxcb patches.
Yay for remote pair programming via bugzilla/irc! (Sorry for the rapid
fire noise for everyone else.)

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--- Comment #6 from Alan Coopersmith <alan.coopersmith-QHcLZuEGTsvQT0dZR+***@public.gmane.org> 2012-08-30 05:05:26 UTC ---
Fixes pushed to git master for next releases:

To ssh://git.freedesktop.org/git/xorg/app/xwininfo
53564df..aedc2ec master -> master

To ssh://git.freedesktop.org/git/xcb/libxcb
ed93a6a..ff53285 master -> master

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=53242

Alan Coopersmith <***@oracle.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|App/other |App/xwininfo