[Bug 17010] Bad error handling in Multi-threaded environment

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010


Jamey Sharp <jamey-sH+B+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
QAContact| |xcb-***@public.gmane.org




--- Comment #6 from Jamey Sharp <jamey-sH+B+***@public.gmane.org> 2009-10-09 10:04:57 PST ---
Would you explain more clearly what you expected to happen when you run your
test program? The extra thread has no effect on its behavior for me. Perhaps
you could propose a different test program that doesn't involve colormaps?

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #7 from ykaston <ykaston-***@public.gmane.org> 2009-10-11 05:06:51 PST ---
Created an attachment (id=30270)
--> (http://bugs.freedesktop.org/attachment.cgi?id=30270)
Locked simplified test

I have added some pthread locking that allows the secondary thread to start and
get to XNextEvent before the main thread starts with its test. Instead of
resulting in "failed when npixels == 54" (first step in the loop), it exits
with: "XIO: fatal IO error 11 (Resource temporarily unavailable) on X server
"<machine>:0.0"
after 7 requests (6 known processed) with 0 events remaining."
If still needed, I can test with some other syncronous API that may process
protocol errors.

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #8 from ykaston <ykaston-***@public.gmane.org> 2010-01-17 07:36:21 PST ---
I have made some modification to the libX11 - XCB integration that resolved
this issue.
Would love to get some review for these changes.

I am attaching the suggested solution.

Yaakov

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #9 from ykaston <ykaston-***@public.gmane.org> 2010-01-17 07:37:30 PST ---
Created an attachment (id=32679)
--> (http://bugs.freedesktop.org/attachment.cgi?id=32679)
Suggested fix, part I

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #10 from ykaston <ykaston-***@public.gmane.org> 2010-01-17 07:38:16 PST ---
Created an attachment (id=32680)
--> (http://bugs.freedesktop.org/attachment.cgi?id=32680)
Suggested solution, part II

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010

Post by bugzilla-daemon-CC+
I have made some modification to the libX11 - XCB integration that resolved
this issue.
Would love to get some review for these changes.
I am attaching the suggested solution.

it's easier to review your changes if you attach a patch against the
current tree rather than complete files where it's impossible to tell
what you changed.

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #12 from ykaston <ykaston-***@public.gmane.org> 2010-01-17 08:43:50 PST ---
Created an attachment (id=32685)
--> (http://bugs.freedesktop.org/attachment.cgi?id=32685)
Patch for suggested solution

As requested, a patch file...

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #13 from Josh Triplett <josh-CC+***@public.gmane.org> 2010-01-17 18:19:17 PST ---
Your patch header suggests that you worked from libX11 1.2. To make it easier
for us to review, can you please verify that the bug in question still exists
with current libX11 (1.3.3), and that your patch still applies there?

Thank you.

[bugzilla-daemon-CC+]

http://bugs.freedesktop.org/show_bug.cgi?id=17010





--- Comment #14 from ykaston <ykaston-***@public.gmane.org> 2010-01-17 23:28:15 PST ---
I did make the fix on top of 1.2. And the bug is still there in 1.3.3.

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=17010

--- Comment #15 from ro <rayneolivetti-/***@public.gmane.org> 2011-01-19 17:52:25 PST ---
The bug is still there in 1.4.0

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=17010

--- Comment #16 from Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> 2011-09-24 22:31:20 PDT ---
As mentioned above, the patches to fix this were based on an old libX11.
Please provide an updated patch based on libX11 master (or at least 1.4.x) so
that it can have some hope of applying.

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=17010

Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |2011BRB_Reviewed

[bugzilla-daemon-CC+]

https://bugs.freedesktop.org/show_bug.cgi?id=17010

Jeremy Huddleston <jeremyhu-CC+***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch, regression
Severity|blocker |critical

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=17010

Adam Jackson <***@nwnk.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID

--- Comment #17 from Adam Jackson <***@nwnk.net> ---
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you
continue to experience issues with current releases.